Skip to content

fix: 🐞 improve Processes topology layout - #604

Merged
pierpman merged 6 commits into
skupperproject:mainfrom
pierpman:fix/602
Sep 30, 2026
Merged

pierpman merged 6 commits into
skupperproject:mainfrom
pierpman:fix/602

Conversation

@pierpman

@pierpman pierpman commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

Improves the Processes topology layout by replacing the force-based combo layout with G6's combo-combined layout and an embedded antv-dagre layout.

The new configuration arranges nodes from left to right and uses explicit rank and node spacing. This resolves the overlap reported in #602 for the tested scenarios and produces a more structured and readable layout for grouped process nodes.

Additional context

  • Updated LAYOUT_TOPOLOGY_COMBO in layout.ts from force to combo-combined.
  • Added an embedded antv-dagre layout with:
    • rankdir: 'LR'
    • ranksep: 45
    • nodesep: 30
  • Removed the previous force-layout clustering parameters.
  • Reduced the configured node size and explicitly set combo padding and spacing to zero.

The layout configuration is part of the shared SkGraph component, with the Processes topology being the scenario addressed by this PR.

How to test

  1. Run the Console against a Network Observer with multiple grouped processes, or use the available mock data.
  2. Navigate to the Processes topology view.
  3. Verify that process nodes are arranged clearly.
  4. Verify that the node overlap reported in Processes topology: nodes rendered as tiny dots spread across a large canvas #602 is no longer present.
  5. Verify that combo boundaries, labels, and edges remain readable.
  6. Verify that zoom, pan, selection, and fit-to-view continue to work.
  7. Resize the browser and confirm that the topology remains usable.

Screenshots

Real Network Observer data

Before

image

After

image

Mock data

Before

image

After

image

@pwright pwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with mock data, looks great

@c-kruse c-kruse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fgiorgetti fgiorgetti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pierpman
pierpman merged commit bc0cec5 into skupperproject:main Sep 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Processes topology: nodes rendered as tiny dots spread across a large canvas

4 participants