chore: remove User-Agent allowlist check to support all npm-compatible clients#87
Merged
Merged
Conversation
Owner
|
Hey @sonmezonur, thanks for raising the PR! I'll take a look shortly and run a few tests. The original reason for the user-agent checks was to something do with npm vs pip support, but that may not actually be required. |
Contributor
Author
|
Hello @sktan. Have you had a chance to look into it? |
Owner
|
LGTM - Seems to work ok, merging it in 👍 |
Owner
|
@sonmezonur i'll create a release in a couple of hours, sorry for the delay! |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thanks for building and maintaining this project.
The current User-Agent allowlist rejects requests from npm-compatible clients whose User-Agent doesn't match the expected patterns. My specific use case is Unity Package Manager (UPM), which sends
User-Agent: axios/1.7.7because its internal resolver runs as a Node.js subprocess using Axios.If there isnt a specific reason for the check, can we remove it? Happy to make it opt-in via config instead if you'd prefer — let me know.