fix(git): time out cached commands - #559
Open
SR0725 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Git widgets use the cached command runner in
src/utils/git.ts. On a cache miss, that runner called Git without a timeout, so a blocked Git process could also block the status line indefinitely.This applies the existing five-second command boundary used by the other Git runner. A timeout still follows the current failure path: the widget gets no Git value and the result is cached normally.
Validation
bun test src/utils/__tests__/git.test.ts(53 passed)bun test(1,868 passed)bun run lintbun run buildThe regression assertion verifies that every cached Git command receives the five-second timeout. The compatibility risk is limited to Git commands that take longer than five seconds; those now return no widget value instead of blocking the process.
Fixes #557