Skip to content

CI: prevent xgboost build-script panic in Rust build & test workflow - #8

Merged
singjc merged 3 commits into
developfrom
copilot/fix-rust-build-test-job
Sep 9, 2026
Merged

singjc merged 3 commits into
developfrom
copilot/fix-rust-build-test-job

Conversation

Copilot AI commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

The Rust build & test GitHub Actions job failed during cargo build --features xgboost when xgboost_lib-sys panicked on a missing target/debug/deps path. This PR hardens the workflow by creating that path before the xgboost-enabled build step.

  • Root cause addressed

    • xgboost_lib-sys build script canonicalizes target/debug/deps and panics if it is absent on a clean runner.
  • Workflow change

    • Added an explicit directory creation step in .github/workflows/rust.yml immediately before the xgboost build step.
  • Resulting execution order

    • Standard build
    • Ensure xgboost output dir exists
    • XGBoost-feature build
- name: Build
  run: cargo build --verbose

- name: Ensure xgboost output directory exists
  run: mkdir -p target/debug/deps

- name: Build with xgboost features
  run: cargo build --verbose --features xgboost

Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Rust build & test CI: prevent xgboost build-script panic in Rust build & test workflow Sep 9, 2026
Copilot AI requested a review from singjc September 9, 2026 19:10
@singjc

singjc commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Co-authored-by: singjc <32938975+singjc@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: fb8522e0-4e91-431d-8640-dae2afc7ef02

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot the GHA is still failing? https://github.com/singjc/redeem/actions/runs/34393258999/job/102646318068?pr=8

You’re right — it was still failing in the same xgboost build-script path. I pushed b3e3774, which switches CI to use the system XGBoost library (libxgboost-dev + XGBOOST_LIB_DIR=/usr/lib/x86_64-linux-gnu) so xgboost_lib-sys no longer hits the brittle prebuilt-download/canonicalize path.

@singjc
singjc marked this pull request as ready for review September 9, 2026 21:36
@singjc
singjc merged commit f87c78f into develop Sep 9, 2026
4 checks passed
@singjc
singjc deleted the copilot/fix-rust-build-test-job branch September 9, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants