Skip to content

improvement(ci): target acceptance work and reuse validated build caches - #9583

Merged
waleedlatif1 merged 12 commits into
stagingfrom
codex/ci-targeted-caches
Nov 2, 2026
Merged

waleedlatif1 merged 12 commits into
stagingfrom
codex/ci-targeted-caches

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Select independent acceptance jobs from the real task graph, including separate docs site and platform-consumer checks.
  • Build docs once, run isolated acceptance groups in parallel, and reuse validated content and incremental build caches with bounded retention.
  • Reuse desktop native outputs only when source, toolchain, checksums, executable modes, architectures, and signatures validate; balance four whole-file smoke shards and seed trusted branch caches.
  • Bound organization-search failure diagnostics, reduce fixture process overhead, and reclaim only closed-PR merge-ref caches.

Type of Change

  • Performance improvement and bug fix

Testing

Full root tests (660 script cases, 39,291 app passes plus eight existing skips, and every workspace), lint, all 29 workspace type-checks, 62 repository audits, block-registry validation, actionlint, and ShellCheck. Real Git/Turbo selection scenarios; generator cold/warm, deletion, and partial-cache controls; native corruption/invalidation controls; and real organization-search success/failure cleanup proofs.

Hosted docs passed generator/source, all 2,998 corpus checks, fresh PostgreSQL search and platform consumption, all six example languages, Chromium, and WebKit. Hosted desktop preserved all 126 case/status identities (111 pass, 15 existing skips), with packaged smoke green. Both integration provision paths retain all prior cases. Final-head CI passed; Greptile 5/5, cubic clear, zero open threads. Timings and exact coverage comparisons are recorded in the validation comment.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 2, 2026 20:40
@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 2, 2026 9:04pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 26 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain from this review.

Summary

This PR narrows acceptance work and reuses validated docs and desktop build caches.

  • CI runs only the acceptance jobs tied to changed task inputs.
  • Documentation builds reuse valid page outputs and clear obsolete modules.
  • Desktop smoke jobs reuse checked native builds and run across four shards.
  • Organization-search failures capture evidence quickly and clean up each resource.
  • Closed pull requests reclaim caches tied to their merge refs.
  • Test setup changes keep the tested behavior the same.

Reviews (3) · Last reviewed commit: "improvement(ci): partition desktop accep..." · Reviewed by Greptile

Comment thread .github/workflows/docs-negotiation.yml Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 26 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 26 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Final validation is clean on 158dfdba35ce768b754203f15889f8114f45e878: all selected checks passed, Greptile reports 5/5 on that commit, cubic reports no issues, and every review thread is resolved.

  • Desktop: four shards completed in 6m11s, versus 7m51s for the preceding warm three-shard run. Test tail fell 285→208s. All 126 case/status identities are unchanged (111 passed, 15 existing skips), packaged smoke passed 3/3, and all five jobs reused validated native outputs.
  • Docs: the warm-content run completed in 5m53s; the final run completed in 11m43s after shared-package changes invalidated content. Both have identical 3,333 case/status results. Content compilation improved 95.374→19.349s on the controlled same-key reuse; Next compilation improved 16→2.6s. The final critical path also contains 291s of recorded job-completion gaps, so the faster total is not universal and those gaps are not attributed to a proven provider cause.
  • Main CI: final complete first attempt passed in 9m04s. Its actual merge tree includes newer production source and correctly required a cold build; this is not a same-source cache-hit speed claim. Both schema provision paths preserve prior cases, and organization search remains 19/19 with the same screenshot inventory.

The neutral secret advisory matches only disposable localhost PostgreSQL fixture URLs. The two newer staging PRs also have complete green checks and clean reviews; their delta has no material interaction with these changes. The actual combined staging tree will be verified after squash merge.

@waleedlatif1
waleedlatif1 merged commit 1a14c87 into staging Nov 2, 2026
91 checks passed
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Post-merge validation is complete on squash commit 1a14c8736ef694d02b598bc9b8f044a8424cbdef.

  • The squash tree exactly matches git merge-tree of its actual staging parent and the reviewed head.
  • Full check-only validation passed all 42 jobs on that exact combined commit, including both integration provision paths and the newer upstream browser-approval cases. Organization search passed 19/19 with unchanged screenshot inventory. This supported check-only dispatch avoided waiting behind the separate deployment workflow; the deployment was left untouched.
  • Post-merge docs passed in 8m07s with initially cold push caches. All 3,333 case/status results exactly match the PR validation.
  • Trusted native cache seeding passed both Node versions, compiled and signed universal outputs, and saved matching staging-scoped fingerprints. PR smoke/package jobs correctly skipped on this push.
  • Closed-PR cleanup passed; no cache entries remain under this PR merge ref.

Final PR review remains Greptile 5/5, cubic clear, zero open threads. No additional test retries, assertion removals, or source changes were needed after merge.

@waleedlatif1
waleedlatif1 deleted the codex/ci-targeted-caches branch November 2, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant