Repository navigation
fix(people): keep a suspended manager link on edit and never fail the org layout on the People lookup - #9526
Merged
Merged
Conversation
… org layout on the People lookup
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryPreserves a person's stored manager link when that manager is suspended. Makes the organization's People navigation lookup fall back to hidden navigation when it fails.
No actionable issues found. Tests were inspected, not run. Reviews (1) · Last reviewed commit: "fix(people): keep a suspended manager li..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
managerMemberId: nulland a title-only save overwrote the stored link. The person now carries the storedmanagerMemberId(the displayedmanagersummary stays null for a suspended manager), the modal sends it back, andupdatePersononly validates a manager that changed — consistent with import, which keeps stored links the file doesn't mention. A suspended member is still refused as a new managercanBrowsePeopleuncaught, so a flag/permission lookup error failed every org page for flag-on orgs. It now logs and hides the People nav, and runs alongside the layout's other lookups instead of adding a serial round tripType of Change
Testing
apps/sim/scripts/test-people-e2e.ts(real HTTP + Postgres): suspend a manager, GET showsmanager: null+ storedmanagerMemberId, a title-only PUT keeps the link, a suspended member is refused as a new manager; fails on the pre-fix codeChecklist
test-auditauthoring gate)