Skip to content

fix(people): keep a suspended manager link on edit and never fail the org layout on the People lookup - #9526

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/people-suspended-manager
Oct 31, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/people-suspended-manager

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Editing a person whose manager is suspended silently cleared the manager link: reads hide suspended people, so the modal seeded managerMemberId: null and a title-only save overwrote the stored link. The person now carries the stored managerMemberId (the displayed manager summary stays null for a suspended manager), the modal sends it back, and updatePerson only validates a manager that changed — consistent with import, which keeps stored links the file doesn't mention. A suspended member is still refused as a new manager
  • The org layout awaited canBrowsePeople uncaught, so a flag/permission lookup error failed every org page for flag-on orgs. It now logs and hides the People nav, and runs alongside the layout's other lookups instead of adding a serial round trip

Type of Change

  • Bug fix

Testing

  • New check in apps/sim/scripts/test-people-e2e.ts (real HTTP + Postgres): suspend a manager, GET shows manager: null + stored managerMemberId, a title-only PUT keeps the link, a suspended member is refused as a new manager; fails on the pre-fix code
  • biome on changed files; type-check, People E2E and the full gate in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 31, 2026 6:02pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Preserves a person's stored manager link when that manager is suspended. Makes the organization's People navigation lookup fall back to hidden navigation when it fails.

  • People edits keep a suspended manager link unless you change it.
  • The organization layout contains People access lookup errors.

No actionable issues found. Tests were inspected, not run.

Reviews (1) · Last reviewed commit: "fix(people): keep a suspended manager li..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 1559a18 into staging Oct 31, 2026
58 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/people-suspended-manager branch October 31, 2026 18:10

This branch was previously deployed

1 inactive deployment
Preview — 2e9adcd8 Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant