Repository navigation
fix(extension): isolate embedded pages from tracking - #9480
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Confidence score: 4/5
- In
google-context.ts, the early return can leavecurrentGooglePageContextstale when an SPA visits/extension, so a later public route may be attributed to the previous page. Clear or refresh the context when leaving/extension.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/consent/google-context.ts">
<violation number="1" location="apps/sim/lib/consent/google-context.ts:54">
P2: This early return leaves `currentGooglePageContext` stale during an SPA visit to `/extension`. Returning to a public route without a full reload then attributes it to the previous public page rather than the sanitized extension referrer; record or clear extension context before suppressing events.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge; no actionable issue was found. SummaryPrevents shared tracking loaders from registering on extension pages, including encoded paths.
Reviews (1) · Last reviewed commit: "fix(extension): isolate embedded pages f..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run test: 42,033 passed, 8 existing skips.Checklist