Skip to content

fix(extension): isolate embedded pages from tracking - #9480

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/extension-store-hygiene
Oct 30, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/extension-store-hygiene

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Prevent shared marketing and analytics loaders from registering on embedded extension pages, including encoded paths.
  • Block app-emitted Google events for extension URLs and remove scope IDs from extension referrals to public pages.

Type of Change

  • Bug fix

Testing

  • Root bun run test: 42,033 passed, 8 existing skips.
  • Consent and navigation checks: 50 passed. Five new regressions fail before the fix; reverting each of the three guards independently makes its regression fail.
  • Root lint, 62 audits, 29 workspace type-checks, artifact generators, and the block-registry check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing; new tests pass the test-audit authoring gate
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 30, 2026 5:54pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Confidence score: 4/5

  • In google-context.ts, the early return can leave currentGooglePageContext stale when an SPA visits /extension, so a later public route may be attributed to the previous page. Clear or refresh the context when leaving /extension.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/lib/consent/google-context.ts">

<violation number="1" location="apps/sim/lib/consent/google-context.ts:54">
P2: This early return leaves `currentGooglePageContext` stale during an SPA visit to `/extension`. Returning to a public route without a full reload then attributes it to the previous public page rather than the sanitized extension referrer; record or clear extension context before suppressing events.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/consent/google-context.ts Resolved
@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issue was found.

Summary

Prevents shared tracking loaders from registering on extension pages, including encoded paths.

  • Embedded extension pages stay out of shared tracking.

Reviews (1) · Last reviewed commit: "fix(extension): isolate embedded pages f..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit c17cb55 into staging Oct 30, 2026
69 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/extension-store-hygiene branch October 31, 2026 00:05

This branch was previously deployed

1 inactive deployment
Preview — 67bdd502 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant