Skip to content

fix(ci): fail the promote wait on a digest lookup error instead of retrying it - #9430

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/ci-promote-lookup-errors-fatal
Oct 29, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/ci-promote-lookup-errors-fatal

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • promote-app-image.sh waited for the moved tag with until [ "$(get-ecr-image-digest.sh …)" = "$DIGEST" ]. A failing command substitution inside a test condition doesn't trip set -e, so a real lookup error (an AWS error, or a malformed response) was retried until the 60s deadline and then reported as "did not resolve … within 60s".
  • The lookup now happens in the loop body as an assignment, so a failed lookup stops the script with its own error. A tag that hasn't propagated yet is still retried up to the deadline, and the AWS CLI's own retries still cover transient errors.
  • Raised on the release PR v0.9.37: workspace files paging and search, token sealing by default, scim hardening, db indexes #9426.

Type of Change

  • Bug fix

Testing

  • Ran the script in a Linux container with stubbed docker/aws:
    • stale read that catches up: changed=true
    • unchanged retag: changed=false
    • tag that never resolves: fails at the deadline
    • first push with no previous tag: changed=true
    • lookup error after the push (new case): fails immediately with exit 1. The previous script swallowed it, retried until the deadline and printed the propagation error.
  • shellcheck, bash -n

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 29, 2026 1:16am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This change appears safe to merge.

Summary

promote-app-image.sh now stops when a digest lookup fails instead of retrying until the propagation deadline.

  • The promotion wait stops when an ECR digest lookup fails.

Reviews (1) · Last reviewed commit: "fix(ci): fail the promote wait on a dige..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit a34e2e7 into staging Oct 29, 2026
68 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/ci-promote-lookup-errors-fatal branch October 29, 2026 02:03

This branch was successfully deployed

1 active deployment
Preview — 0c81d5e3 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant