Skip to content

fix(scripts): normalize Windows path separators in validation scripts - #9400

Open
sahooarnav2007-gif wants to merge 1 commit into
simstudioai:mainfrom
sahooarnav2007-gif:fix/cross-platform-script-paths
Open

sahooarnav2007-gif wants to merge 1 commit into
simstudioai:mainfrom
sahooarnav2007-gif:fix/cross-platform-script-paths

Conversation

@sahooarnav2007-gif

Copy link
Copy Markdown

Summary

Normalizes path separators in scripts/check-tool-registry-boundary.ts and scripts/check-api-validation-contracts.ts to ensure consistent cross-platform execution on Windows environments.

Problems Resolved:

  1. check-tool-registry-boundary.ts: collectEntries() emitted relative paths with Windows backslashes (\), causing all 85 entries to fail comparison against check-tool-registry-boundary.baseline.json as unbaselined/removed.
  2. check-api-validation-contracts.ts: INDIRECT_ZOD_ROUTES.has(relativePath) failed for all 55 exempted routes due to backslash paths, falsely reporting non-Zod routes increased from 0 to 55. In addition, routeFamily() prefix stripping and isApiRouteHandler() / isClientHookFile() failed when comparing POSIX paths against Windows directory paths.

Product update (if relevant)

N/A — Developer tooling and CI verification fix for Windows environments.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: _____

Testing

  • Verified bun run check:tool-registry-boundary on Windows: passes cleanly with all 85 entry graphs matching baseline.
  • Verified bun run check:api-validation on Windows: passes cleanly with 895/895 Zod-backed routes and 0 non-Zod routes.
  • Verified code style and formatting with bunx biome check.

Checklist

  • Code follows project style guidelines
  • Self reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

terminal_verification

@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

This PR makes path comparisons consistent on Windows in two validation scripts.

  • The API validation check uses forward slashes when matching routes and folders.
  • The registry boundary check writes discovered entry names with forward slashes.

No actionable issues found. This review checked the code paths; it did not run the scripts on Windows.

Reviews (1) · Last reviewed commit: "fix(scripts): normalize Windows path sep..." · Reviewed by Greptile

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant