Skip to content

fix(tailscale): omit whitespace expiry and share response schemas - #9399

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/tailscale-review-followup
Oct 27, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/tailscale-review-followup

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Treat whitespace-only auth-key expiry as unset so Tailscale applies its default lifetime.
  • Share DNS and tailnet-settings response mappings, output schemas, and response types.

Type of Change

  • Bug fix and cleanup

Testing

  • VITEST_MAX_WORKERS=2 bun run test (full root gate)
  • 48 focused parser and workflow-builder cases; the whitespace-expiry wire regression fails before its fix and when the normalization guard is removed
  • bun run lint, bun run type-check, bun run check:test-types, and all 61 check:audits checks
  • Block registry check against origin/staging; regenerated metadata and integration documentation
  • Cross-checked auth-key expiry semantics against the official Tailscale OpenAPI specification

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 27, 2026 8:06am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

This PR treats whitespace-only auth-key expiry as unset and shares the DNS and tailnet-settings response definitions.

  • Whitespace-only auth-key expiry now counts as unset.
  • DNS get and set tools use the same response shape.
  • Tailnet settings get and update tools use the same response shape.

Reviews (2) · Last reviewed commit: "fix(tailscale): omit whitespace expiry a..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 marked this pull request as draft October 27, 2026 07:54
@waleedlatif1
waleedlatif1 force-pushed the codex/tailscale-review-followup branch from 9a695a1 to 2b8f68a Compare October 27, 2026 08:06
@waleedlatif1 waleedlatif1 changed the title fix(tailscale): reject blank inputs and share response schemas fix(tailscale): omit whitespace expiry and share response schemas Oct 27, 2026
@waleedlatif1
waleedlatif1 marked this pull request as ready for review October 27, 2026 08:06
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 614eaf7 into staging Oct 27, 2026
68 of 69 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 2b8f68a3 Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant