Repository navigation
fix(tailscale): omit whitespace expiry and share response schemas - #9399
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryThis PR treats whitespace-only auth-key expiry as unset and shares the DNS and tailnet-settings response definitions.
Reviews (2) · Last reviewed commit: "fix(tailscale): omit whitespace expiry a..." · Reviewed by Greptile |
waleedlatif1
marked this pull request as draft
October 27, 2026 07:54
waleedlatif1
force-pushed
the
codex/tailscale-review-followup
branch
from
October 27, 2026 08:06
9a695a1 to
2b8f68a
Compare
waleedlatif1
marked this pull request as ready for review
October 27, 2026 08:06
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
VITEST_MAX_WORKERS=2 bun run test(full root gate)bun run lint,bun run type-check,bun run check:test-types, and all 61check:auditschecksorigin/staging; regenerated metadata and integration documentationChecklist
test-auditauthoring gate)