Repository navigation
chore(db): drop the job log schedule index the occurrence unique index covers - #9398
Open
waleedlatif1 wants to merge 1 commit into
Open
waleedlatif1 wants to merge 1 commit into
waleedlatif1 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] This PR appears safe to merge. SummaryRemoves the redundant
Reviews (1) · Last reviewed commit: "chore(db): drop the job log schedule ind..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Turn on auto-fix | Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
job_execution_logs_schedule_id_idx: the(schedule_id, occurrence_at)unique index added for scheduled-job occurrences leads withschedule_id, so it serves every lookup and theworkflow_scheduleFK check the single-column index didDROP INDEX CONCURRENTLY IF EXISTS, so it takes no table lock and replays safelyType of Change
Testing
bun run check:migrations(backward-compatible),drizzle-kit generatereports no schema changesbun run lint,bun run check:audits(61 audits)Checklist
test-auditauthoring gate)