Repository navigation
fix(ci): queue migrate runs per environment instead of letting them overlap - #9394
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge. SummaryAdds per-environment job concurrency to
waleedlatif1 explicitly accepts replacement of pending migration jobs. The PR description notes that cancelled migrations cannot deploy.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrencygroup (migrate-<environment>,cancel-in-progress: false) to the reusablemigrate.yml, so two migrate jobs against the same database queue instead of overlappingci.yml'sci-<ref>group already runs push runs on one branch one at a time. The gap is a manualworkflow_dispatchofmigrate.yml, which has no group and can run at the same time as a CI migrate for the same environmentmigrate.ts's advisory lock already stops versioned and script migrations from running at once, but the second runner gives up after 30 minutes while the job allows 300 for long index builds, so a long migration fails the other run. On dev,db:push's try-lock fails right away instead of waitinggithubcontext, andmigrate-*can never match the caller'sci-*group, so the two can't deadlockcancelled.promoterequiresneeds.migrate.result == 'success', so a cancelled migrate never deploysType of Change
Testing
actionlintonmigrate.ymlpassescirun's migrate job confirms itChecklist
test-auditauthoring gate)