Repository navigation
fix(ci): find the last IndexNow submission through its check run, not the run's job list - #9384
Merged
Merged
Conversation
… the run's job list The indexnow job resolved its diff base by listing each earlier main run's jobs at 100 per page, and GitHub's jobs API answers that page with HTTP 502 for every re-run workflow run. The first release scanned back to such a run and failed the step, so no submission ever recorded a success and every later run would fail the same way. Look up the one `indexnow` check run per commit instead (small, and it counts every attempt), treat a lookup that errors as no success, and when no success is in view diff from the oldest run in view so URLs no submission ever covered are still sent.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
Turn on auto-fix | Re-trigger cubic
Contributor
 [Medium impact] The PR appears safe to merge. SummaryChanges how
No actionable issues found. Review was based on code inspection; no runtime tests were run. Reviews (1) · Last reviewed commit: "fix(ci): find the last IndexNow submissi..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
indexnowjob (from improvement(library): single JSON-LD source, Markdown articles, and IndexNow pings #9355) resolved its diff base by listing each earlier main run's jobs atper_page=100. GitHub's jobs API returns HTTP 502 for that page on every re-run workflow run (reproduced repeatedly; the same runs answer at smaller pages, single-attempt runs answer fine). The first release run scanned back to such a run and failed the step; since no submission ever recorded a success, every later run would fail the same way (non-blocking, so deploys were unaffected).indexnowcheck run per commit (/commits/{sha}/check-runs?check_name=indexnow&filter=all): a small response that also counts every attempt of a re-run.checks: readto the job for the check-runs API.Type of Change
Testing
collectIndexNowUrls(no submission) returned 151 URLs including the last release's library posts.per_page=100for re-run runs on every try.actionlintonci.yml: no findings on the changed lines. The job still only runs on main after a successful cutover and remainscontinue-on-error.Checklist
test-auditauthoring gate)