refactor(files): early returns in the path resolver

Author: waleedlatif1

apps/sim/lib/workspace-files/application/file-context.ts

@@ -93,17 +93,16 @@ function requireWorkspaceFileContext<C extends ActiveWorkspaceFileContext>(
  */
 async function resolveFileId(input: WorkspaceFileContextInput): Promise<string> {
   if (!input.acceptVfsPath || !isWorkspaceFileVfsPath(input.fileId)) return input.fileId
-  const file =
-    input.assertedWorkspaceId === undefined
-      ? null
-      : await resolveFileReference(
-          { entityType: 'workspace', entityId: input.assertedWorkspaceId },
-          input.fileId
-        ).catch((error: unknown) => {
-          if (error instanceof OrchestrationError && error.code === 'conflict') return null
-          throw error
-        })
-  if (!file) throw new OrchestrationError('not_found', 'File not found')
+  const notFound = new OrchestrationError('not_found', 'File not found')
+  if (input.assertedWorkspaceId === undefined) throw notFound
+  const file = await resolveFileReference(
+    { entityType: 'workspace', entityId: input.assertedWorkspaceId },
+    input.fileId
+  ).catch((error: unknown) => {
+    if (error instanceof OrchestrationError && error.code === 'conflict') return null
+    throw error
+  })
+  if (!file) throw notFound
   return file.id
 }