refactor(files): one file-reference input type for the path-aware use cases

Author: waleedlatif1

apps/sim/lib/workspace-files/application/delete-workspace-file.ts

@@ -7,17 +7,15 @@ import {
   deleteWorkspaceFile,
 } from '@/lib/uploads/contexts/workspace/file-manager'
 import { defineAuthorizedWorkspaceFileUseCase } from '@/lib/workspace-files/application/authorized-workspace-file-use-case'
-import { resolveActiveWorkspaceFileContext } from '@/lib/workspace-files/application/file-context'
+import {
+  resolveActiveWorkspaceFileContext,
+  type WorkspaceFileReferenceInput,
+} from '@/lib/workspace-files/application/file-context'
 import { fileOperations } from '@/lib/workspace-files/application/operations'
 
 const logger = createLogger('DeleteWorkspaceFile')
 
-export interface DeleteWorkspaceFileInput {
-  fileId: string
-  assertedWorkspaceId?: string
-  /** Accept the file's exact `files/…` VFS path as `fileId` (the public v2 surface). */
-  acceptVfsPath?: boolean
-}
+export type DeleteWorkspaceFileInput = WorkspaceFileReferenceInput
 
 export interface DeleteWorkspaceFileResult {
   id: string

apps/sim/lib/workspace-files/application/file-context.ts

@@ -12,15 +12,19 @@ import { isWorkspaceFileVfsPath } from '@/lib/vfs/path'
 import { ownedFileKind } from '@/lib/workspace-files/owned-files'
 import { matchesFileOwner } from '@/lib/workspace-files/ownership'
 
-export interface WorkspaceFileContextInput {
+/** How a use case names one workspace file: its id, or with `acceptVfsPath` its exact VFS path. */
+export interface WorkspaceFileReferenceInput {
   fileId: string
+  assertedWorkspaceId?: string
   /**
    * Also accept the file's exact `files/…` VFS path as `fileId`, resolved inside
    * `assertedWorkspaceId` to a live workspace file. Only the public v2 surface sets it; every
    * other caller passes ids, and a path-shaped string there stays an unknown id.
    */
   acceptVfsPath?: boolean
-  assertedWorkspaceId?: string
+}
+
+export interface WorkspaceFileContextInput extends WorkspaceFileReferenceInput {
   includeDeleted?: boolean
   /**
    * Admit a chat upload (`context = 'mothership'`) addressed by its own id. Only read

apps/sim/lib/workspace-files/application/read-workspace-file-metadata.ts

@@ -11,14 +11,13 @@ import {
   type WorkspaceFileRecord,
 } from '@/lib/uploads/contexts/workspace/file-manager'
 import { defineAuthorizedWorkspaceFileUseCase } from '@/lib/workspace-files/application/authorized-workspace-file-use-case'
-import { resolveActiveWorkspaceFileContext } from '@/lib/workspace-files/application/file-context'
+import {
+  resolveActiveWorkspaceFileContext,
+  type WorkspaceFileReferenceInput,
+} from '@/lib/workspace-files/application/file-context'
 import { fileOperations } from '@/lib/workspace-files/application/operations'
 
-export interface ReadWorkspaceFileMetadataInput {
-  fileId: string
-  assertedWorkspaceId?: string
-  /** Accept the file's exact `files/…` VFS path as `fileId` (the public v2 surface). */
-  acceptVfsPath?: boolean
+export interface ReadWorkspaceFileMetadataInput extends WorkspaceFileReferenceInput {
   /**
    * Opt into the archived lifecycle set. It relaxes only the `deleted_at` predicate on the
    * canonical row lookup — the workspace the file resolves to, the asserted-workspace check,

apps/sim/lib/workspace-files/application/rename-workspace-file.ts

@@ -8,16 +8,15 @@ import {
   type WorkspaceFileRecord,
 } from '@/lib/uploads/contexts/workspace/file-manager'
 import { defineAuthorizedWorkspaceFileUseCase } from '@/lib/workspace-files/application/authorized-workspace-file-use-case'
-import { resolveActiveWorkspaceFileContext } from '@/lib/workspace-files/application/file-context'
+import {
+  resolveActiveWorkspaceFileContext,
+  type WorkspaceFileReferenceInput,
+} from '@/lib/workspace-files/application/file-context'
 import { fileOperations } from '@/lib/workspace-files/application/operations'
 
 const logger = createLogger('RenameWorkspaceFile')
 
-export interface RenameWorkspaceFileInput {
-  fileId: string
-  assertedWorkspaceId?: string
-  /** Accept the file's exact `files/…` VFS path as `fileId` (the public v2 surface). */
-  acceptVfsPath?: boolean
+export interface RenameWorkspaceFileInput extends WorkspaceFileReferenceInput {
   name: string
 }