Skip to content

Ponytail cleanup: preview-env helper consolidation, duplicated name and issue strings (2026-10-05) #280

Description

@simpros

Parent

Ponytail audit 2026-10-05 (weekly-ponytail-audit, job ad3283353401). Report: ~/.hermes/cron/output/ad3283353401/2026-10-05_08-34-11.md.
Audited read-only at sprout 56f0168 (checkout clean, on main). Re-verify each path before deleting — this batch is the cleanest of the week.

What to build

  1. packages/preview-env/src/health.ts:28 vs governance.ts:7 — two parseDurationMs under one name with different grammars. Consolidate. ~15-20 LOC.
  2. apps/cli/src/yaml.ts:109-119 — healthIssueMessage is the last *IssueMessage living in the CLI while its siblings moved into the package. ~12 LOC.
  3. apps/cli/src/yaml.ts:156-172 + apps/server/src/http/deploy.ts:236-241 — duplicated preview.env.<key> issue string. ~15-25 LOC.
  4. apps/server/src/preview/naming.ts:8-9 vs e2e/harness/docker.ts:6-8 — identical container-name builder. ~5-10 LOC.
  5. e2e/lifecycle.test.ts:106,149 — inline database name instead of the canonical previewDbName.
  6. restricted-role.ts:33-35 vs app-deployment/pg-env.ts:38-40 — identical companion-role error. ~3-8 LOC.
  7. README.md:40 — points at docs/site/index.html, which is generated output and not checked in. 1 line.
  8. packages/preview-db/src/names.ts:17-24 — validateSlug and validateServiceName duplicate one regex. ~4 LOC.
  9. packages/preview-env/src/index.ts:111 — PreviewVolumeIssue barrel export consumed only by a test. 1 line.

Not in scope

Human-routed this run: the un-export batch (deploy.ts:429/475/490, forge/gitlab.ts:12, telemetry/destination.ts:14 + CLI helpers) and the duplicated escapeHtml (docs/site/html.ts:2-7 vs server/src/http/dashboard.ts:53-58).

Acceptance

rg proof per removed symbol or duplicated helper; bun run lint, typecheck and bun test green; the e2e harness still provisions previews.

Activity

  1. added this to the v0.9.0 milestone on Oct 5, 2026
  2. simpros commented on Oct 5, 2026

    @simpros
    OwnerAuthor

    Implemented in #281 (all 9 items; suite + typecheck green).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions