Repository navigation
Conversation
…eleted Go binary monitoringServices() still named /usr/local/bin/sb-event-collector as the two-node-event-collector container's command. sbcli's translate-go rewrote it as simplyblock_core/services/two_node_event_collector.py and removed the Go toolchain stage that built that binary, so every pod running this image crash-loops on "stat /usr/local/bin/sb-event-collector: no such file or directory" (confirmed live on cluster91). Point the service entry at the module like every other one, drop the now-dead twoNodeEventCollectorBinary const, and update the two tests that pinned the old binary path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/event-collector, installed at/usr/local/bin/sb-event-collector) intosimplyblock_core/services/two_node_event_collector.py, and removed the Dockerfile stage that built the Go binary.managementapi.go'smonitoringServices()still pointed thetwo-node-event-collectorcontainer at the deleted binary path, so any control-plane image built fromtranslate-go(or once it merges, from sbcli main) crash-loops that container:stat /usr/local/bin/sb-event-collector: no such file or directory.translate-goimage.Changes
two-node-event-collectornow usesmodule: "simplyblock_core/services/two_node_event_collector.py", same as every other monitoring service.twoNodeEventCollectorBinaryconst.TestTheServicePoolsRunWhatTheyDeclare's special-case branch,TestTheTwoNodeServicesNameWhatTheImageShips'swantmap).Test plan
make test(full suite, envtest included): all packages pass,controlplane79.7% coverage.simplyblock-monitoringDeployment on cluster91 with the fixed command;two-node-event-collectorcontainer came upRunningand loggedTwo-node event collector startedcleanly against real FoundationDB/RPC.