Allow setting iparms before analysis via iparm_overrides#25
Open
bodono wants to merge 1 commit intosimpeg:mainfrom
Open
Allow setting iparms before analysis via iparm_overrides#25bodono wants to merge 1 commit intosimpeg:mainfrom
bodono wants to merge 1 commit intosimpeg:mainfrom
Conversation
Some Pardiso iparms (e.g., 10 and 12) affect the analysis stage, but previously there was no way to set them before __init__ called _analyze(). Add an iparm_overrides dict parameter to MKLPardisoSolver.__init__ that applies overrides after handle creation but before the analysis phase. Fixes simpeg#24 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iparm_overridesdict parameter toMKLPardisoSolver.__init__()that applies overrides after handle creation but before_analyze()is callediparm[10]andiparm[12]) to take effect properlyset_iparm()method, so invalid indices/parameters are rejectedTest plan
test_iparm_overrides— overrides iparm[10] and iparm[12] on SPD matrix, verifies values and solver correctnesstest_iparm_overrides_nonsymmetric— overrides on nonsymmetric matrixtest_iparm_overrides_invalid— verifies IndexError/ValueError for bad indicestest_iparm_overrides_default_none— verifies backward compatibility (no overrides preserves defaults)Fixes #24
🤖 Generated with Claude Code