Fix transform() dropping AUTOINCREMENT from INTEGER PRIMARY KEY columns#793
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix transform() dropping AUTOINCREMENT from INTEGER PRIMARY KEY columns#793ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
Calling .transform() on a table with INTEGER PRIMARY KEY AUTOINCREMENT recreated the table without the AUTOINCREMENT keyword, silently changing the table's behaviour so that deleted row IDs could be reused. The fix adds an autoincrement parameter to create_table_sql() and detects AUTOINCREMENT in the existing schema before calling it from transform_sql().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling .transform() on a table with INTEGER PRIMARY KEY AUTOINCREMENT silently dropped the AUTOINCREMENT keyword, meaning deleted row IDs could be reused in subsequent inserts. This fix detects AUTOINCREMENT in the existing table schema and preserves it in the recreated table by passing it through create_table_sql(). Fixes #602
📚 Documentation preview 📚: https://sqlite-utils--793.org.readthedocs.build/en/793/