Repository navigation
ci: run the tests on Python 3.14 as well as 3.12; hello prints the same everywhere - #178
Merged
Merged
Conversation
The test job ran only on 3.12, the oldest supported Python, while local runs use 3.14, so a behaviour that differs between the two ends of the range was caught by neither alone: 3.12's asyncio.run takes only a coroutine, where 3.14's takes any awaitable (#177). The matrix keeps 3.12 on all three systems and adds 3.14 on Linux. CONTRIBUTING says so.
…atform hello.pyfun printed cbrt 27.0 and its comments promised 3.0, but glibc's cbrt is not correctly rounded, so Linux and most cloud notebooks print 3.0000000000000004. 64.0 gives 4.0 on Linux and Windows alike, and the example now prints the same on both. DESIGN notes that, as in Python, a float maths function's last digit follows the platform's C library.
simontreanor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testjob ran only on 3.12, the oldest supported Python, while local runs use 3.14, so neither caught a behaviour that differs between the two ends of the range. #177 hit exactly that: 3.12'sasyncio.runtakes only a coroutine, where 3.14's takes any awaitable. The matrix keeps 3.12 on all three systems and adds 3.14 on Linux, one extra job. CONTRIBUTING says so.None of the required status checks change. They come from the kernel and wheels workflows, and the
testjob isn't one of them.Also:
examples/hello.pyfunprintedcbrt 27.0and its comments promised3.0, but glibc'scbrtisn't correctly rounded, so Linux and most cloud notebooks print3.0000000000000004. It now uses64.0(exact on Linux and Windows), and the whole example prints the same on Windows/3.14 and Linux/3.12. DESIGN notes that, as in Python, a float maths function's last digit follows the platform's C library. The compiler'scbrtlowering is unchanged.