Repository navigation
diagnostics: the def hint suggests let greet _ = … for a parameterless function - #176
Merged
Merged
Conversation
…ess function `def greet():` was answered with `let greet () = …`, which does not parse: Pyfun has no `()` parameter pattern, and a function that takes nothing is written `let greet _ = …` and called as `greet ()`. The test now also checks that every suggested spelling parses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #175.
def greet():was answered withlet greet () = …, which does not parse: Pyfun has no()parameter pattern, and a function that takes nothing is writtenlet greet _ = …and called asgreet (). The hint now suggests that, and the test also checks that every suggested spelling parses, so a wrong suggestion fails the test instead of reaching a user.