Open
Conversation
added 8 commits
April 12, 2026 15:33
- Was passing null as kernel, causing Graph.VirtualArray test to fail - Now looks up kernel by name and properly sets parameters
- vxFastCornersNode: Was passing null kernel, now looks up kernel by name - vxOpticalFlowPyrLKNode: Fixed parameter count to match kernel registration Graph.VirtualArray still failing on user kernel lookup (vxAddUserKernel)
- vxFastCornersNode: Now uses proper kernel lookup - vxOpticalFlowPyrLKNode: Fixed parameter count to 7 params - vxAddUserKernel: Now registers kernel in REFERENCE_TYPES as VX_TYPE_KERNEL - Removed debug eprintln! statements from execute_node
The mapped data pointer was being returned from a local Vec that gets dropped at the end of the function. Fixed by getting the pointer BEFORE moving the Vec into the HashMap. Also cleaned up vxUnmapArrayRange to avoid unsafe memory reconstruction.
- vxFastCornersNode: Now looks up kernel by name - vxOpticalFlowPyrLKNode: Fixed parameter count to 7 - vxAddUserKernel: Now registers with VX_TYPE_KERNEL type - vxGetParameterByIndex: Now syncs with node's parameters - dispatch_kernel_with_border: Added stub for user kernels - Removed debug eprintln! statements Remaining: User kernel execution needs kernel callback field in VxCUserKernel
- VXU arithmetic operations fixes - Image operation improvements - Color conversion enhancements (NV21, packed YUV support) Work in progress from multi-agent conformance effort.
- Added kernel function field to VxCUserKernel struct - Fixed vxAddUserKernel to accept kernel execution function - Made USER_KERNELS and VxCUserKernel fields public for access from c_api - vxCreateGenericNode now checks USER_KERNELS for num_params Graph.VirtualArray still failing - parameter 2 not being set correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress for OpenVX 1.3.1 conformance.
Status:
Changes: