Fix GetDocumentationUri resource lookup for missing doc file - #1510
Merged
Conversation
#1392) GetDocumentationUri stripped the extension from DocumentationFile before calling GetResource, so "ailca.html" became "ailca" and no longer matched the embedded resource name SIL.Archiving.Resources.ailca.html. Pass the full filename so the missing file can be created from the resource. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
imnasnainaec
marked this pull request as ready for review
June 16, 2026 19:28
Contributor
imnasnainaec
changed the title
myieye
approved these changes
Jun 18, 2026
Contributor
Author
There are global files being modified in those tests, so they would require significant refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1392
ArchiveAccessProtocol.GetDocumentationUristripped the extension fromDocumentationFilebefore callingGetResource(e.g."ailca.html"→"ailca"), so the lookup no longer matched the embedded resource manifest nameSIL.Archiving.Resources.ailca.htmland the missing documentation file could not be created from the resource.The fix passes the full filename to
GetResource.Where the bug was introduced
PR #1317 ("Renamed project to SIL.Windows.Forms.Archiving", merge commit
0dfeebe3) rewrote the resource accessor soGetResourceprependsSIL.Archiving.Resources.and requires the full filename including the extension. The extension-stripping logic inGetDocumentationUriwas carried over against this new accessor, producing the mismatch.Testing
The covering test is in a fixture categorized
SkipOnTeamCity, so it does not run on CI and must be run by hand:SIL.Archiving.Tests.AccessProtocolListTests.GetDocumentationUri_ProgramDirectoryNotSpecified_ReturnsRootedPathToExistingFileDevin review: https://app.devin.ai/review/sillsdev/libpalaso/pull/1510
🤖 Generated with Claude Code
This change is