Add per-job timeouts to CI - #399
Merged
Merged
Conversation
Set timeout-minutes on both jobs so a hung job fails fast instead of running to the 6-hour default: build (10m; recent runs ~5m) and publish-test-results (5m; normally <30s). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
imnasnainaec
approved these changes
Aug 25, 2026
imnasnainaec
left a comment
imnasnainaec
left a comment
Contributor
There was a problem hiding this comment.
@imnasnainaec reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on hahn-kev).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently a job got cancelled after running for 6 hours, on a job that normally runs for less than 5 minutes. So I've added some timeouts to our jobs.
AI summary
Adds
timeout-minutesto both jobs in.github/workflows/ci-cd.yml, which previously had none (so a hung job could run to GitHub's 6-hour default).build(matrix: windows-latest / ubuntu-22.04)publish-test-resultsThe
buildtimeout is shared across the matrix, so it's set for the slowerwindows-latestleg with comfortable headroom.Test plan
This change is