Update to version 7.* of SIL.Chorus.Mercurial (7.01 current, 7.2.2 upcoming) - #396
Update to version 7.* of SIL.Chorus.Mercurial (7.01 current, 7.2.2 upcoming)#396rmunn wants to merge 2 commits into
Conversation
We specify `7.*` instead of `7.0.*` because there is currently an open PR updating SIL.Chorus.Mercurial to version 7.2.2, and a `7.*` spec will allow downstream Chorus-using projects to smoothly update to version 7.2.2 of Mercurial later without requiring a new Chorus PR to be tested and approved.
|
I have downloaded the SIL.Chorus.Mercurial 7.0.1.58 NuGet package and run the Chorus unit tests against it, on both Linux and Windows. All tests pass. I have not yet built the Chorus installer and verified that it would work without changes in FLExBridge. That was a concern raised by @hahn-kev in sillsdev/Mercurial4Chorus#30 (review), so it's worth testing. (By someone who has a working setup to build the Chorus installer and test it with FLExBridge and FieldWorks, i.e. not me). |
|
Installer is failing because it cannot find certain files, which were actually unnecessary in our Chorus Mercurial package (they were part of TortoiseHg and Chorus never uses them) and which I therefore deliberately removed in version 7 of the Mercurial package. I'll go through and see about removing them from the installer, though someone with more experience with WiX may need to help me confirm that the installer will then properly remove them from a user's computer when upgrading from 6.5 to 7.0.1 (or 7.2.2). |
Seven files deleted between Mercurial 6.5.1 and 7.0.1, and one new file, which the installer needs to know about in order to build correctly.
1 participant
Version 7.0.1 of SIL.Chorus.Mercurial has been released, and tested to work on both Windows and Linux with no Chorus code changes needed (all unit tests pass). It's time to update the package version that Chorus depends on, so that downstream projects (like LexBox) that want to update to Mercurial 7.x can do so.
We specify
7.*instead of7.0.*because there is currently an open PR updating SIL.Chorus.Mercurial to version 7.2.2, and a7.*spec will allow downstream Chorus-using projects to smoothly update to version 7.2.2 of Mercurial later without requiring a new Chorus PR to be tested and approved.It would also be possible to say "version 6.5.1.43 or later", i.e.:
Or, to keep allowing all
6.5packages (6.5.1.18 was the first 6.5 package released):That would allow all future SIL.Chorus.Mercurial packages, including
8.xand later which don't exist yet. But it's entirely possible that Mercurial 8 will include breaking changes that would need a corresponding change to SIL.Chorus in order to compile, so it's probably safer to just accept7.*rather than a truly open-ended NuGet package range.This change is