TT 7048 assigned to me - #580
Draft
gtryus wants to merge 2 commits into
Draft
Conversation
gtryus
commented
Sep 3, 2026
gtryus
commented
Contributor
- create filter method
- refresh
- test cases
- Implemented the refilterSheet function to reapply filters to existing sheet rows based on the assigned-to-me filter state. - Created unit tests for the refilterSheet function to ensure correct filtering behavior. - Updated the Sheet component to utilize the new refilterSheet function for improved performance and maintainability. - Added a new test file for assignedToMe filtering scenarios.
gtryus
marked this pull request as draft
September 3, 2026 21:29
…y for assigned-to-me scenarios
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes have no unresolved approval-blocking issues.
Pull request overview
Fixes TT-7048 so “Assigned to Me” filtering correctly handles the final passage in flat sheets.
Changes:
- Extracts reusable sheet refiltering logic.
- Prevents valid final flat rows from being hidden.
- Adds focused regression tests.
File summaries
| File | Description |
|---|---|
src/renderer/src/components/Sheet/ScriptureTable.tsx |
Uses the extracted filtering helper. |
src/renderer/src/components/Sheet/refilterSheet.ts |
Implements sheet refiltering and the flat-row fix. |
src/renderer/src/components/Sheet/index.ts |
Exports the new helper. |
src/renderer/src/__tests__/refilterSheet.assignedToMe.test.ts |
Covers assigned-to-me filtering regressions. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.