TT 7051 mobile scroll - #579
Merged
Merged
Conversation
gtryus
commented
Sep 3, 2026
gtryus
commented
Contributor
- remember where we were in the mobile view
- remember where we were in the sheet view
added 2 commits
September 3, 2026 15:51
…the project. Added definitions for Sections, Passage Cards, and Current Passage in CONTEXT.md. Updated PassageCard component to include unique IDs and data attributes for better accessibility. Modified PlanView to restore the Current Passage from local storage and ensure it is in view when loaded. Added tests to verify the restoration and scrolling behavior of the Current Passage card.
…t passage highlighting. Added isCurrent prop to PassageCard for accessibility and visual indication. Updated PlanView to manage current passage state and ensure it is scrolled into view. Modified tests to verify current passage behavior.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is focused, consistent with existing sheet behavior, and adequately tested.
Pull request overview
Extends Current Passage restoration to the mobile/card view, aligning it with the sheet view.
Changes:
- Persists, highlights, and scrolls to the Current Passage.
- Adds Cypress coverage for restoration and persistence.
- Documents related user-facing terminology.
File summaries
| File | Description |
|---|---|
PlanView.tsx |
Restores and persists Current Passage state. |
PlanView.cy.tsx |
Tests scrolling, highlighting, and persistence. |
PassageCard.tsx |
Adds current-state styling and accessibility metadata. |
CONTEXT.md |
Defines Sections & Passages terminology. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sarahentzel
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.