Skip to content

TT-7623 fix: keep three-digit references on one line on mobile #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nabalone wants to merge 1 commit into
base: develop
Choose a base branch
from
+22 −3
Draft

TT-7623 fix: keep three-digit references on one line on mobile #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/renderer/src/components/PassageDetail/mobile/MarkVerses/EditReferenceDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,20 @@ export default function EditReferenceDropdown({
fullWidth
maxWidth="xs"
>
<DialogTitle id="edit-reference-dialog-title">
{`${title} ${limits}`}
<DialogTitle
id="edit-reference-dialog-title"
sx={{
// Slightly smaller than the default h6 so the common
// "Edit Reference for 124.7-425.2" fits on one line on a phone.
fontSize: '1.1rem',
}}
>
{title}{' '}
{/* Keep the time-limit range together so it never breaks mid-number
(e.g. "124.7-" / "425.2") when it has three digits (TT-7623). */}
<Box component="span" sx={{ whiteSpace: 'nowrap' }}>
{limits}
</Box>
</DialogTitle>
<DialogContent sx={{ pt: 1 }}>
<Box
Expand Down
9 changes: 8 additions & 1 deletion src/renderer/src/components/PassageDetail/mobile/MarkVerses/MarkVersesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ export default function MarkVersesTable({
<TableCell
sx={{
whiteSpace: 'nowrap',
width: '42%',
// Shrink to the limits text's own width (rather than a fixed
// 42%) so the reference column keeps enough room to stay on
// one line even for three-digit chapter:verse ranges (TT-7623).
width: '1%',
pl: 1.5,
backgroundColor: 'inherit',
py: 0.75,
Expand Down Expand Up @@ -299,6 +302,10 @@ export default function MarkVersesTable({
aria-label={`verse-reference-${rowIndex}`}
sx={{
color: invalid ? 'error.main' : 'text.primary',
// Keep the reference (e.g. "119:10b-11a") on a single
// line instead of wrapping when it has three-digit
// chapter/verse numbers (TT-7623).
whiteSpace: 'nowrap',
}}
>
{reference.value || '-'}
Expand Down
Loading