refactor: internalization resource dialogs and artifact category selector - #480
refactor: internalization resource dialogs and artifact category selector#480nabalone wants to merge 12 commits into
Conversation
Keep the selected resource kind synchronized across mode changes and align upload and record action spacing. Co-authored-by: Cursor <cursoragent@cursor.com>
…rce wizard ref Make SelectArtifactCategory always render the free-solo Autocomplete (type to filter or add a category), dropping the old Select + "add new" menu variant, the now-unused `autocomplete` prop, and its dead helpers. Rename `wizardAddRef` to `isAddingAudioResourceRef` in the desktop and mobile PassageDetail artifacts components for clarity and remove stale TODO comments. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Only pass onSpeaker into MediaUploadContent for Media uploads so Resource/ProjectResource keeps hasRights and the file drop target stays usable. Co-authored-by: Cursor <cursoragent@cursor.com>
Raise the dialog to 700px when space allows, and only pin the record button with space-between in full-height mobile panes. Co-authored-by: Cursor <cursoragent@cursor.com>
Wrap MediaRecord so height:100% cannot resolve against DialogContent and open a gap above the record button. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace magic action strings shared by AddResource and both artifact views. Co-authored-by: Cursor <cursoragent@cursor.com>
Lift section/passage/general resource scope into parent state so radios stay in sync across Upload/Record remounts without a local sync effect. Co-authored-by: Cursor <cursoragent@cursor.com>
88b8855 to
c2ddd39
Compare
|
@nabalone This branch conflicts with 25 conflict hunks across 7 files. Most of the volume is mechanical (prettier churn, plus buttons that #537 "Button overhaul" already converted the same way you would), but three items are real decisions:
For reference, the other three conflicted PRs did resolve cleanly and are pushed: #531, #515, #484. Generated by Claude Code |
Refactoring pass over the Passage Detail → Internalization resource flow. No Jira ticket.
What changed
AddResourceAction— Add Resource menu actions are now typed with an enum instead of loose values.ResourceData/PassageDetailArtifacts(+ mobile) — internalization resource state cleanup.SelectArtifactCategory— simplified the artifact category selector.UploadRecordToggle— new shared upload/record toggle component.PassageRecordDlg— substantial rework (a TODO is left in place noting it should be renamed).TranscriberAdmin-en-1.2.xliffwith regeneratedmodel.tsx/reducers.tsxand strings JSON.Notes
develop(currently behind); rebase before marking ready.🤖 Generated with Claude Code