Change package_name allocation method to dupeSentinel#96
Closed
cers000 wants to merge 1 commit into
Closed
Conversation
更新zig0.16新的api,dupeZ已弃用
Owner
|
Please change to: if (builtin.zig_version.major == 0 and builtin.zig_version.minor <= 15)
// Deprecated: Older Zig version compatibility
try b.allocator.dupeZ(...)
else
try b.allocator.dupeSentinel(...) |
Author
|
好吧是我搞错了,zig0.16只是弃用dupeZ,并没有从标准库中删除dupeZ,0.17版本才正式删除了dupeZ,改用dupeSentinel,我用的版本是0.17.0-dev.356,那这里没必要更改 |
Owner
|
@cers000 Im happy to support 0.17.x+, Use the change I suggested above so it’s also backwards compatible with Zig 0.15.0 and Zig 0.16.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
更新zig0.16新的api,dupeZ已弃用