Skip to content

Fix bugs in default handling and refactor code for less complexity#21

Merged
jason-jackson merged 7 commits into
mainfrom
feature/refactor
Oct 31, 2025
Merged

Fix bugs in default handling and refactor code for less complexity#21
jason-jackson merged 7 commits into
mainfrom
feature/refactor

Conversation

@jason-jackson
Copy link
Copy Markdown
Contributor

@jason-jackson jason-jackson commented Oct 30, 2025

Changed

  • Refactor BuildReplacementsFromEnv to reduce complexity
  • Use t.Fatal for tests instead of Error and FailNow
  • Use log.Fatal instead of Print and os.Exit(1)

Fixed

  • Fixed issue where defaults would not correctly be set
  • Fixed issue where default LETS_ENCRYPT_CA would not be changed to staging URI

@jason-jackson jason-jackson requested review from a team, briskt, ethancanne and hobbitronics and removed request for a team October 30, 2025 15:04
@sonarqubecloud
Copy link
Copy Markdown

Comment thread entrypoint_test.go
Comment thread entrypoint.go
@briskt briskt changed the title Refactor code for less complexity Fix bugs in default handling and refactor code for less complexity Oct 31, 2025
@jason-jackson jason-jackson merged commit 9fe918e into main Oct 31, 2025
3 checks passed
@jason-jackson jason-jackson deleted the feature/refactor branch October 31, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants