-
Notifications
You must be signed in to change notification settings - Fork 2
Rewrite: SignalWire Resources doc #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Manny-r31
wants to merge
9
commits into
main
Choose a base branch
from
Manny/resources-page-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bb8f63c
Rewrote Resources page to more accurately describe the resource ecosy…
Manny-r31 9e8ecbc
Small formatting update
Manny-r31 e126937
Merge branch 'main' into Manny/resources-page-rewrite
hey-august fbb8f61
Merge branch 'main' into Manny/resources-page-rewrite
hey-august 765b019
Merge branch 'main' into Manny/resources-page-rewrite
Manny-r31 928dbea
Merge branch 'main' into Manny/resources-page-rewrite
Manny-r31 9f6ecf9
Merge branch 'main' into Manny/resources-page-rewrite
Manny-r31 7185fa0
Merge branch 'main' into Manny/resources-page-rewrite
hey-august beae7f5
Merge branch 'main' into Manny/resources-page-rewrite
hey-august File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get clarity from Product on this before publishing, and also update the Resource Addresses snippet that populates the Addresses doc.
I have heard of 3 different reserved contexts:
public,private, andexternal. We need to nail down exactly what each of these does.