Skip to content

fix(package): keep docmd engine out of runtime deps - #1

Merged
devin-ai-integration[bot] merged 3 commits into
mainfrom
devin/1792346075-drop-docmd-prod-dep
Oct 18, 2026
Merged

devin-ai-integration[bot] merged 3 commits into
mainfrom
devin/1792346075-drop-docmd-prod-dep

Conversation

@espetro

@espetro espetro commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Moves @docmd/engine-rust out of the published runtime dependency graph and keeps it as a docs-time dev dependency instead, refreshes the local scriptc pin to 0.3.6, and exposes the --print build flag as a typed option.

  • docmd build auto-downloads its Rust runtime when it cannot resolve it; because it was absent, it rewrote this package's production dependencies, so consumers installing unplugin-scriptc also installed the native docmd engine and could hit package-manager install/build warnings. With the engine pinned in devDependencies, pnpm docs:build still works while packed consumers only get unplugin plus the declared scriptc/typescript peers.
  • Lockfile refresh: local scriptc 0.3.1 → 0.3.6 (peer range ^0.3.0 already covered it; this pins the version the repo's tests actually run against).
  • New print?: "native-link-info" | "diagnostics" option in ScriptcBuildOptions mapping to --print, closing the last gap against the scriptc build flag surface (the repo invariant is that every build flag is reachable without the args escape hatch). --fail-on is coverage-only and intentionally not added — the plugin implements the same behavior via failOnBlockers.

Verified:

  • pnpm test (11 pass, 3 e2e skips — no working scriptc bin on this box)
  • pnpm typecheck, pnpm lint, pnpm fmt:check
  • pnpm docs:build
  • pnpm pack + tarball install in a scratch consumer (no docmd dependency pulled in)

Link to Devin session: https://app.devin.ai/sessions/fdad18fe8868493fa0fd701709938f44
Open in Devin Desktop: https://app.devin.ai/desktop/session/fdad18fe8868493fa0fd701709938f44?variant=devin
Requested by: @espetro

@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Deploying unplugin-scriptc with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6bc78a7
Status: ✅  Deploy successful!
Preview URL: https://0f3b916f.unplugin-scriptc.pages.dev
Branch Preview URL: https://devin-1792346075-drop-docmd.unplugin-scriptc.pages.dev

View logs

@devin-ai-integration
devin-ai-integration Bot merged commit ce65362 into main Oct 18, 2026
3 checks passed
@devin-ai-integration
devin-ai-integration Bot deleted the devin/1792346075-drop-docmd-prod-dep branch October 18, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant