Repository navigation
fix(package): keep docmd engine out of runtime deps - #1
Merged
devin-ai-integration[bot] merged 3 commits intoOct 18, 2026
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Deploying unplugin-scriptc with
|
| Latest commit: |
6bc78a7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0f3b916f.unplugin-scriptc.pages.dev |
| Branch Preview URL: | https://devin-1792346075-drop-docmd.unplugin-scriptc.pages.dev |
devin-ai-integration
Bot
deleted the
devin/1792346075-drop-docmd-prod-dep
branch
October 18, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
@docmd/engine-rustout of the published runtime dependency graph and keeps it as a docs-time dev dependency instead, refreshes the local scriptc pin to0.3.6, and exposes the--printbuild flag as a typed option.docmd buildauto-downloads its Rust runtime when it cannot resolve it; because it was absent, it rewrote this package's productiondependencies, so consumers installingunplugin-scriptcalso installed the native docmd engine and could hit package-manager install/build warnings. With the engine pinned indevDependencies,pnpm docs:buildstill works while packed consumers only getunpluginplus the declaredscriptc/typescriptpeers.scriptc0.3.1→0.3.6(peer range^0.3.0already covered it; this pins the version the repo's tests actually run against).print?: "native-link-info" | "diagnostics"option inScriptcBuildOptionsmapping to--print, closing the last gap against thescriptc buildflag surface (the repo invariant is that every build flag is reachable without theargsescape hatch).--fail-onis coverage-only and intentionally not added — the plugin implements the same behavior viafailOnBlockers.Verified:
pnpm test(11 pass, 3 e2e skips — no working scriptc bin on this box)pnpm typecheck,pnpm lint,pnpm fmt:checkpnpm docs:buildpnpm pack+ tarball install in a scratch consumer (no docmd dependency pulled in)Link to Devin session: https://app.devin.ai/sessions/fdad18fe8868493fa0fd701709938f44
Open in Devin Desktop: https://app.devin.ai/desktop/session/fdad18fe8868493fa0fd701709938f44?variant=devin
Requested by: @espetro