Skip to content

fix: keep Outlook conditional commments intact when inlining CSS - #2

Merged
shyim merged 1 commit into
shyim:mainfrom
Simianbv:fix/cssinliner-conditional-comments
Sep 8, 2026
Merged

shyim merged 1 commit into
shyim:mainfrom
Simianbv:fix/cssinliner-conditional-comments

Conversation

@Simian-m

@Simian-m Simian-m commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@shyim

shyim commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Do you have an example mjml wrongly rendered?

@Simian-m

Simian-m commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Sure, do you want the full html and mjml or the use case specifically?

@Simian-m

Simian-m commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author
<mjml>
    <mj-head>
        <mj-font name="Plus Jakarta Sans"
                 href="https://fonts.googleapis.com/css?family=Plus+Jakarta+Sans:400,700&display=swap"/>
        <mj-font name="DM Sans" href="https://fonts.googleapis.com/css?family=DM+Sans:400,700"/>
        <mj-attributes>
            <mj-accordion border="none" padding="4px"/>
            <mj-accordion-element icon-wrapped-url="https://cdn.reclameland.nl/assets/mail/arrow-right.png"
                                  icon-unwrapped-url="https://cdn.reclameland.nl/assets/mail/arrow-up.png"
                                  icon-height="12px" icon-width="12px"/>
            <mj-accordion-title background-color="#fff" color="#031017" padding="16px" font-size="15px"/>
            <mj-accordion-text background-color="rgb(249, 244, 242)" padding="16px" color="#505050" font-size="15px"/>
            <mj-all font-family="'DM Sans', Roboto, Open Sans, Helvetica, Arial, sans-serif" font-size="15px"
                    line-height="20px" padding="0px"/>
            <mj-class name="jakarta"
                      font-family="'Plus Jakarta Sans', DM Sans, Roboto, Open Sans, Helvetica, Arial, sans-serif"
                      font-weight="bold"/>
            <mj-class name="button" background-color="rgb(249, 244, 242)" color="#fff" font-size="15px"
                      border-radius="4px"/>
            <mj-class name="c2a" background-color="rgb(250, 188, 67)" color="#231f20" font-size="15px"
                      font-weight="bolder" border-radius="100px"/>
        </mj-attributes>
        <mj-style inline="inline">a {
            text-decoration: underline;
            color: inherit;
        }
        </mj-style>
        <mj-style>
            @media only screen and (max-width: 480px) {
                .mobile-hide {
                    display: none !important;
                    height: 0 !important;
                    overflow: hidden !important;
                }

                .mobile-center div {
                    text-align: center !important;
                }
            }

            .foa {
                text-decoration: none !important;
            }

            h1, h2, h3, h4, h5, h6 {
                font-family: 'Plus Jakarta Sans', DM Sans, Roboto, Open Sans, Helvetica, Arial, sans-serif;
            }
        </mj-style>
    </mj-head>

    <mj-body background-color="rgb(249, 244, 242)" width="600px">
        <mj-section padding="0px">
            <mj-column width="100%">
                <mj-image src="https://cdn.reclameland.nl/mail/assets/header-bar.png" alt="logo"
                          width="600px" padding="0px 0"/>
            </mj-column>
        </mj-section>

        <mj-section background-color="rgb(250, 188, 67)" padding="0px" border-radius="0px 0px 8px 8px">
            <mj-column width="150px" css-class="mobile-hide"></mj-column>
            <mj-column width="300px">
                <mj-image src="https://cdn.reclameland.nl/mail/assets/logo-slogan.png" alt="logo reclameland.nl"
                          width="180px" padding="8px" align="center"/>
            </mj-column>
            <mj-column width="150px" css-class="mobile-hide">
                <mj-social padding="16px 0px" icon-size="16px">
                    <mj-social-element text-padding="4px" href="{{domain}}/account" src="https://cdn.reclameland.nl/mail/assets/32_account.png">
                        <span padding-left="8px">mijn account</span>
                    </mj-social-element>
                </mj-social>
            </mj-column>
        </mj-section>

        <mj-section>
            <mj-column>
                <mj-spacer height="12px"/>
            </mj-column>
        </mj-section>
        
        <mj-section background-color="#ffffff" padding="24px 32px" border-radius="8px">
            <mj-column>
                <mj-text>
                    {!! $contentBody !!}
                </mj-text>
            </mj-column>
        </mj-section>

        <mj-section>
            <mj-column>
                <mj-spacer height="12px"/>
            </mj-column>
        </mj-section>

        <mj-section background-color="#ffffff" padding="16px" border-radius="8px">
            <mj-column>
                <mj-text font-weight="bolder" padding-left="16px">
                    Veelgestelde vragen
                </mj-text>
                <mj-accordion padding="16px 0px" border="1px solid rgb(249, 244, 242)">
                    <mj-accordion-element>
                        <mj-accordion-title>Wat gebeurt er na een bestandsafwijzing?</mj-accordion-title>
                        <mj-accordion-text>
                            In de meeste gevallen is het een kleine wijziging en wanneer je een nieuw bestand upload, gaan we bestand nogmaals checken. Zodra je nieuwe bestand goedgekeurd wordt, wordt je order in behandeling genomen.
                        </mj-accordion-text>
                    </mj-accordion-element>
                    <mj-accordion-element>
                        <mj-accordion-title>Hoe lang heb ik om een nieuw bestand te uploaden?</mj-accordion-title>
                        <mj-accordion-text>
                            Wij hanteren over het algemeen een tijdsvak van 4 weken voordat we een order annuleren als er nog geen geldig bestand is aangeleverd.
                        </mj-accordion-text>
                    </mj-accordion-element>
                    <mj-accordion-element>
                        <mj-accordion-title>Kan ik mijn bestelling annuleren?</mj-accordion-title>
                        <mj-accordion-text>
                            Dat ligt eraan, wanneer je geen andere producten hebt besteld of deze ook nog niet goedgekeurd zijn, dan kun je je bestelling nog annuleren.
                        </mj-accordion-text>
                    </mj-accordion-element>
                </mj-accordion>
                <mj-text padding-left="16px" padding-top="12px">
                    Staat jouw vraag hier niet tussen, kijk dan ook bij de andere <a
                    href="{{domain}}/klantenservice/veelgestelde-vragen?utm_source=transactional_mail&amp;utm_medium=email&amp;utm_campaign=account-deleted&amp;utm_content=faq">
                    veelgestelde vragen
                </a> of reageer op deze mail om in contact te komen.
                </mj-text>
            </mj-column>
        </mj-section>

        <mj-section>
            <mj-column>
                <mj-spacer height="12px"/>
            </mj-column>
        </mj-section>

        <mj-section background-color="rgb(35, 31, 32)" border-radius="8px 8px 0px 0px" padding="16px">
            <mj-group width="50%">
                <mj-column padding="16px 0px" width="30%">
                    <mj-image src="https://cdn.reclameland.nl/mail/assets/48_account-white.png" width="40px"/>
                </mj-column>
                <mj-column padding="16px 0px">
                    <mj-text align="left" color="#fff" font-size="16px" font-weight="bold" padding-bottom="8px">
                        <a class="foa" href="{{domain}}/account">Account</a>
                    </mj-text>
                    <mj-text align="left" color="#fff">
                        Bekijk de status van je <a class="foal" href="{{domain}}/account/bestellingen">orders</a> of ga naar jouw <a class="foal" href="{{domain}}/account/favorieten">favorieten</a>.
                    </mj-text>
                </mj-column>
            </mj-group>
            <mj-group width="50%">
                <mj-column padding="16px 0px" width="30%">
                    <mj-image src="https://cdn.reclameland.nl/mail/assets/48_contact-white.png" width="40px"/>
                </mj-column>
                <mj-column padding="16px 0px">
                    <mj-text align="left" color="#fff" font-size="16px" font-weight="bold" padding-bottom="8px">
                        <a class="foa" href="{{domain}}/klantenservice">Contact</a>
                    </mj-text>
                    <mj-text align="left" color="#fff">
                        Wij helpen je graag. Onze <a class="foal" href="{{domain}}/klantenservice">klantenservice</a> staat voor je klaar.
                    </mj-text>
                </mj-column>
            </mj-group>
        </mj-section>

        <mj-section background-color="rgb(250, 188, 67)" padding="0px 0">
            <mj-column width="100%">
                <mj-image src="https://cdn.reclameland.nl/mail/assets/footer-bar.png" alt="logo"
                          width="600px" padding="0px 0"/>
            </mj-column>
        </mj-section>

        <mj-section background-color="rgb(250, 188, 67)" padding="10px" border-radius="0px 0px 8px 8px">
            <mj-column>
                <mj-image src="https://cdn.reclameland.nl/mail/assets/logo.png" width="160px" align="center"
                          padding="10px"/>
            </mj-column>
        </mj-section>

        <mj-section padding="12px 200px">
            <mj-group>
                <mj-column padding-top="4px" padding-left="4px">
                    <mj-image width="32px" src="https://cdn.reclameland.nl/mail/assets/32_facebook.png"
                              href="https://facebook.com/reclameland"/>
                </mj-column>
                <mj-column padding-top="4px" padding-left="4px">
                    <mj-image width="32px" src="https://cdn.reclameland.nl/mail/assets/32_twitter.png"
                              href="https://x.com/reclameland"/>
                </mj-column>
                <mj-column padding-top="4px" padding-left="4px">
                    <mj-image width="32px" src="https://cdn.reclameland.nl/mail/assets/32_instagram.png"
                              href="https://instagram.com/reclameland"/>
                </mj-column>
                <mj-column padding-top="6px" padding-left="4px">
                    <mj-image width="32px" src="https://cdn.reclameland.nl/mail/assets/youtube.png"
                              href="https://youtube.com/reclameland"/>
                </mj-column>
            </mj-group>
        </mj-section>

        <mj-section padding="8px">
            <mj-column>
                <mj-text align="center">© 2007 - {{date('Y')}} Reclameland</mj-text>
            </mj-column>
        </mj-section>
    </mj-body>
</mjml>

@shyim
shyim merged commit 4cce1a3 into shyim:main Sep 8, 2026
7 checks passed
@shyim

shyim commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Thank you!

@Simian-m
Simian-m deleted the fix/cssinliner-conditional-comments branch September 9, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants