Repository navigation
feat: align with MJML 5.4.0 - #1
Merged
Merged
Conversation
Retarget snapshot tests and CI at mjml@5.4.0, add mj-social border and mj-section gutter, and round Outlook column pixel widths so the PHP renderer matches the current JS CLI.
Redirecting CLI stdout added a FILE comment and trailing newline that `mjml --no-minify -o` (used by the drift job) does not emit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mjml@5.2.1tomjml@5.4.0.borderonmj-social/mj-social-element(default0on the icon image) andgutteronmj-section(including%/px, RTL, groups, and Outlook).33.33%of 600px is200px, not199.98px).5.2.2 and 5.3.0 had no renderer-facing changes. The PHP output for the existing fixtures plus the new gutter cases matches
mjml@5.4.0after the test suite's usual HTML normalisation.Test plan
vendor/bin/phpunit— 270 tests, 723 assertionsvendor/bin/phpstan analysevendor/bin/php-cs-fixer fix --dry-run --diffmjml@5.4.0