Skip to content

feat: align with MJML 5.4.0 - #1

Merged
shyim merged 2 commits into
mainfrom
feat/mjml-5.4.0
Aug 19, 2026
Merged

shyim merged 2 commits into
mainfrom
feat/mjml-5.4.0

Conversation

@shyim

@shyim shyim commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Retarget snapshot fixtures and the CI drift job from mjml@5.2.1 to mjml@5.4.0.
  • Port the two 5.4.0 renderer features: border on mj-social / mj-social-element (default 0 on the icon image) and gutter on mj-section (including %/px, RTL, groups, and Outlook).
  • Round Outlook column pixel widths the same way 5.4.0 does (33.33% of 600px is 200px, not 199.98px).

5.2.2 and 5.3.0 had no renderer-facing changes. The PHP output for the existing fixtures plus the new gutter cases matches mjml@5.4.0 after the test suite's usual HTML normalisation.

Test plan

  • vendor/bin/phpunit — 270 tests, 723 assertions
  • vendor/bin/phpstan analyse
  • vendor/bin/php-cs-fixer fix --dry-run --diff
  • CI: PHPUnit on PHP 8.2–8.5, PHPStan, CS-Fixer, snapshot drift vs mjml@5.4.0

shyim added 2 commits August 19, 2026 06:51
Retarget snapshot tests and CI at mjml@5.4.0, add mj-social border
and mj-section gutter, and round Outlook column pixel widths so the
PHP renderer matches the current JS CLI.
Redirecting CLI stdout added a FILE comment and trailing newline that
`mjml --no-minify -o` (used by the drift job) does not emit.
@shyim
shyim merged commit 62dad59 into main Aug 19, 2026
7 checks passed
@shyim
shyim deleted the feat/mjml-5.4.0 branch August 19, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant