fix: avoid double prefix when listing remote WebDAV directory - #1
Open
by-2020-github wants to merge 1 commit into
Open
fix: avoid double prefix when listing remote WebDAV directory#1by-2020-github wants to merge 1 commit into
by-2020-github wants to merge 1 commit into
Conversation
list(remotePath) always re-joined remotePath with baseRemotePath via fullPath(). Callers pass cfg.webdav.remote_path (e.g. /Vol2_Home/codex), which produced a doubled path (/Vol2_Home/codex/Vol2_Home/codex) and an HTTP 404. The error was silently swallowed by .catch(() => []) in api/sync.js and bin/cxsync.js, so the remote file list was always empty: preview always showed 0 files to download, and every sync re-uploaded all local files. Now list() treats a path that is already baseRemotePath (or one of its sub-paths) as absolute and uses it as-is; relative sub-paths still go through fullPath().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list(remotePath) always re-joined remotePath with baseRemotePath via
fullPath(). Callers pass cfg.webdav.remote_path (e.g. /Vol2_Home/codex),
which produced a doubled path (/Vol2_Home/codex/Vol2_Home/codex) and an
HTTP 404. The error was silently swallowed by .catch(() => []) in
api/sync.js and bin/cxsync.js, so the remote file list was always empty:
preview always showed 0 files to download, and every sync re-uploaded all
local files.
Now list() treats a path that is already baseRemotePath (or one of its
sub-paths) as absolute and uses it as-is; relative sub-paths still go
through fullPath().