Fix alert rules and prometheus config for stackdriver metrics#58
Merged
Conversation
Alert rules used old metric names (fastapi_fastapi_*, dataflow_job_user_counter) that no longer exist after switching to Cloud Monitoring via stackdriver-exporter. Updated all rules to use stackdriver_* metrics. Removed otel-collector scrape target from prometheus.yml since it is behind the local-dev profile. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alert_rules.ymlto usestackdriver_*metric names (replaced oldfastapi_fastapi_*anddataflow_job_user_counterreferences that no longer exist after the Cloud Monitoring migration)otel-collectorscrape target fromprometheus.yml(OTel Collector is behindlocal-devprofile, was showing as DOWN)Alert Rule Changes
HighPredictionErrorRate(fastapi_fastapi_*)HighCloudRunErrorRateNoPredictionsFlowing(fastapi_fastapi_*)NoPredictionsFlowingprediction_successHighPredictionLatency(fastapi_fastapi_*)HighPredictionLatencyprediction_latency_ms_meanFeatureFetchFailureSpike(dataflow_job_user_counter)FeatureFetchFailureSpikefetch_failure+fetch_retryHighParseErrorRate(dataflow_job_user_counter)ParseToFetchDropoffPredictionBatchFailureSpike(dataflow_job_user_counter)PredictionRetrySpikeprediction_retryCost-attribution alerts were already using correct
stackdriver_*names — unchanged.Test plan
🤖 Generated with Claude Code