Skip to content

perf(watcher): optimize hot path slicing and attribute access#134

Merged
shenald-dev merged 1 commit into
mainfrom
apex-forge-optimize-watcher-17286215995827958674
May 20, 2026
Merged

perf(watcher): optimize hot path slicing and attribute access#134
shenald-dev merged 1 commit into
mainfrom
apex-forge-optimize-watcher-17286215995827958674

Conversation

@shenald-dev
Copy link
Copy Markdown
Owner

  • Pre-computed _abs_base_path_len and _base_prefix_len to avoid calculating lengths repeatedly inside string slicing.
  • Replaced unnecessary getattr function calls with direct property access for event_type and src_path on the watchdog FileSystemEvent objects.
  • Optimized truthiness checks in wildcard matching.

These small fixes reduce CPU cycles per file event inside high-frequency processing loops, resulting in a cleaner and faster file watcher.


PR created automatically by Jules for task 17286215995827958674 started by @shenald-dev

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@shenald-dev shenald-dev added enhancement New feature or request refactor labels May 20, 2026
@shenald-dev
Copy link
Copy Markdown
Owner Author

Looks good, merging this in. CI is green and everything checks out 👍

Optimize watcher hot path by precomputing lengths and using direct attribute access.

@shenald-dev shenald-dev merged commit 51f5118 into main May 20, 2026
1 check passed
@google-labs-jules
Copy link
Copy Markdown
Contributor

Looks good, merging this in. CI is green and everything checks out 👍

Optimize watcher hot path by precomputing lengths and using direct attribute access.

Acknowledged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant