chore(release): v0.1.26#120
Conversation
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Hey @shenald-dev, heads up — this PR has merge conflicts with To fix: |
|
The performance improvements look good. Please resolve the merge conflicts with main before merging. Consider adding a benchmark or test to verify the hot‑path optimization impact. Reviewed — quality: high |
I have fetched and merged |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
🔄 Re-evaluating based on recent changes: The performance improvements look good. As noted in the review, consider adding a benchmark or test to verify the hot‑path optimization impact before merging. Reviewed — quality: high |
Thank you for the review! I have added a |
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
Optimized the file watcher's ignore filtering hot path by pre-computing string lengths for prefix slicing and streamlining the compound wildcard regex matching loop to avoid redundant conditional evaluations. Also replaced
getattrwith direct attribute access for guaranteedFileSystemEventproperties. Maintained structural correctness and reverted a lock contention regression caught in review. Version bumped to0.1.26.PR created automatically by Jules for task 4255338356982804835 started by @shenald-dev