fix(ui): add ARIA attributes to access policy action toggle - #6882
Merged
Conversation
Add `role="group"` with `aria-label` on the wrapper and `aria-pressed` on each button so screen readers announce the group context and which option is currently selected.
|
Claude finished @luizhf42's task in 28s —— View job Code Review CompleteReviewed 1 file across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is. The added If you push additional changes and want a new review, tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The allow/deny toggle in the access policy drawer is now accessible to screen readers.
Why
The toggle used two plain
<button>elements with no grouping or pressed-state semantics. A screen reader saw two unrelated buttons with no way to tell which was active — selection was conveyed only through color (green/red), violating WCAG 1.4.1.Changes
AccessPolicyDrawer: addedrole="group"andaria-label="Policy action"on the wrapper so assistive tech identifies the buttons as a related set, andaria-pressedon each button so the active option is programmatically exposed.