Prepatory changes for moving to open - #101
Merged
Merged
Conversation
Tests reach for the filesystem helpers exported by the patching code to check that a file exists or to make a directory for a fixture. Route those checks through helpers in the library the tests already link, so that the tests do not care how the patching code spells its filesystem access. This keeps a later change to those helpers out of every test file.
_wmktemp_s reports a failure through its (positive) errno_t return value, so comparing it against zero from below never caught an error.
The check fetched the permissions of the output file itself, resolving the whole path by name once more. Instead let the caller say what it found.
"C:\foo" names the root of drive C, but "C:foo" names foo relative to whatever the current directory on C happens to be. Classifying the second as absolute means it is resolved from a root it does not name. Rejecting absolute names was also the only thing keeping a drive-relative name out of a patch, so is_safe_patch_path() now refuses a colon itself. A colon never appears in a Windows file name, since "file:stream" names an alternate data stream of "file" rather than a file of that name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One small grab bag moving towards openat