Skip to content

fix: Use pull_request instead of pull_request_target in validate-pr-title - #70

Closed
google-admin wants to merge 1 commit into
mainfrom
fix/validate-pr-title-pull-request
Closed

google-admin wants to merge 1 commit into
mainfrom
fix/validate-pr-title-pull-request

Conversation

@google-admin

Copy link
Copy Markdown

Requested by @crwilcox (crwilcox@google.com) ahead of GitHub's November 2, 2026 default policy enforcement blocking pull_request_target workflows on public repositories without an explicit Actions event policy:

Summary

Switches validate-pr-title/validate-pr-title.yaml from on: pull_request_target to on: pull_request:

  • All configured types (opened, reopened, edited, synchronize, assigned, labeled, ready_for_review, review_requested) are supported identically on pull_request.
  • amannn/action-semantic-pull-request only reads pull request title metadata using the default GITHUB_TOKEN (no repository secrets, labels, or comments needed).
  • Once merged to main, .github/workflows/sync-common-workflows.yaml will propagate this update across the downstream shaka-project repositories using validate-pr-title.yaml.

…itle

Co-Authored-By: Otto (Gemini) <gemini-cli@users.noreply.github.com>
@google-cla

google-cla Bot commented Oct 21, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@crwilcox

Copy link
Copy Markdown

I'll recommit this as myself and close this PR

@crwilcox

Copy link
Copy Markdown

#71

@google-admin
google-admin deleted the fix/validate-pr-title-pull-request branch October 21, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants