Repository navigation
feat(config): add select_after_create option for shape and text creation - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new configuration option,
select_after_create, allowing users to control whether newly created shapes and text elements are automatically selected. It updates the Rust backend configuration engine, Lua generator/parser, core input routers, and provides full UI toggle support in the settings modal.Key Changes
select_after_create(defaulting totrue) to the RustAppOptionsstruct, Lua configuration evaluator, and Lua script generator.PointerRouter(for shapes) andtextCommit(for text elements) to conditionally select newly created items based on the configuration setting.Verification & Testing
cargo test) to ensure round-trip correctness ofselect_after_create.vitest) verifyingGeneralTab,SettingsModal,textCommit, andPointerRouterhandle the new configuration correctly when toggled.