Repository navigation
Conversation
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
sagudev
reviewed
Oct 28, 2026
| or "GetJobQueue" in sig | ||
| ): | ||
| sig = sig.replace("&mut JSContext", "&JSContext") | ||
| if ( |
Member
There was a problem hiding this comment.
can we just write the some explanatory comment here why they are here and how were they obtained. I should've written docs for no_gc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike whether a function can GC, information about whether an API method requires a realm to be active does not appear to be statically available or inferrable. Here are some annotations for a few public API methods that use constructs like
cx->compartment()->...orcx->realm()->...without explicitly entering a realm and therefore require that the caller has already done so.Testing: Relevant unit tests were updated.
Servo PR: servo/servo#49371