Repository navigation
ci: Fix ohos verify step and update actions - #838
Merged
Merged
Conversation
Remove the dummy ohos-build script, which only printed a reminder that we now use `cargo-ohos`. Since it didn't exit with -1, the verify CI job did nothing. Switch to cargo ohos instead, same as in the build job. While doing that also update the actions and use a newer SDK. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
sagudev
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dummy ohos-build script, which only printed a reminder that we now use
cargo-ohos. Since it didn't exit with non-zero, the verify CI job did nothing and appeared to pass. Switch to cargo ohos instead, same as in the build job.While doing that also update the actions and use a newer SDK.
Testing: This only changes CI, not mozjs itself.