Repository navigation
ci: Add GH_TOKEN to verify jobs - #837
Merged
Merged
Conversation
We set `MOZJS_ATTESTATION: strict`, so we need to pass in `GH_TOKEN`. Before servo#834, the attestation failing was ignored, so we didn't notice. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
sagudev
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We set
MOZJS_ATTESTATION: strict, so we need to pass inGH_TOKEN. Before #834, the attestation failing was ignored, so we didn't notice.The ohos verification step has been silently broken since the switch to
cargo-ohos- I'll fix that in a follow-up since its unrelated to this PR.Testing: I'm not sure if we can test this without mergining.