[rockwotj]

SpiderMonkey never enables the normalizer's optional icu_properties
dependency, but Cargo still locks optional dependencies that weak
icu_properties?/... features refer to. Its ~2.1.1 requirement then
pins icu_properties for every crate that depends on mozjs, so a crate
that also needs ICU4X 2.2 or later (for example through icu_collator)
fails to resolve, even with the intl feature off.

update.py now rewrites the requirement to a caret 2.1.1 when it
extracts the crate.

Testing: We're using this at Tasklet in a WASM build to successfully
run mozjs, this is needed because we have another crate that uses
ICU but the versions conflict.

[sagudev]

Would it be enough to just relax the version requirement here, because as far as I can tell we still use it

mozjs/mozjs-extracted-crates/properties_glue/Cargo.toml

Line 12 in 730d8bb

icu_properties = "2.1.2"

via other crates, but I guess they are not problematic because of less strict semver?

[rockwotj]

Ah yes relaxing it works too. I'll push a fix to do that. I'm compiling without the intl feature so the properties_glue dependency never resolved, but I'm happy to just relax as that works around the conflicts

[sagudev]

We need to test this in servo before landing too as some earlier experiments showed problems #831 (comment)

[rockwotj]

We need to test this in servo before landing too as some earlier experiments showed problems #831 (comment)

BTW this only changes the version requirement if the intl feature is off - which servo has the feature on so it's still pinned to the existing version

[rockwotj]

We need to test this in servo before landing too as some earlier experiments showed problems #831 (comment)

BTW this only changes the version requirement if the intl feature is off - which servo has the feature on so it's still pinned to the existing version

To verify this I pulled servo and pointed it to this commit and the lockfile is unchanged after regeration, so this only helps folks like me who disable intl and now the version isn't pinned

[rockwotj]

Gentle ping

[sagudev]

LGTM but needs rebase otherwise we cannot land it.

We have no machinery to bump mozjs-extracted-crates versions (cuz integrity check) so we need to wait for new SpiderMonkey bump that will also do the release.

[rockwotj]

thanks all!