Remove redundant clones in html5ever/src/tree_builder/mod.rs - #770
Merged
Conversation
simonwuelker
approved these changes
Aug 6, 2026
simonwuelker
enabled auto-merge
August 6, 2026 23:15
mrobinson
changed the title
html5ever/src/tree_builder/mod.rs
mrobinson
force-pushed
the
remove-clones
branch
from
August 7, 2026 07:45
4df9356 to
e521376
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I am not overlooking anything, I believe these clones are redundant and can thus be safely removed.
For reference, this change was found by an optimizer developed as a research project.
CC @nunoplopes