ci: Secure SemVer check workflow - #769
Open
jschwe wants to merge 1 commit into
Open
Conversation
We can't trust any `cargo` commands in potentially attacker controlled code, see <https://shnatsel.medium.com/do-not-run-any-cargo-commands-on-untrusted-projects-4c31c89a78d6>. We avoid such attacks by moving the potential malicous command (which could do anything with our tokens) to an unprivileged workflow.
Member
Author
|
Tested in my fork: https://github.com/jschwe/html5ever/actions/runs/31150532800/job/92782128612 (Note: Needed to add the labels to my fork first, before being able to test) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't trust any
cargocommands in potentially attacker controlled code, see https://shnatsel.medium.com/do-not-run-any-cargo-commands-on-untrusted-projects-4c31c89a78d6. We avoid such attacks by moving the potential malicous command (which could do anything with our tokens) to an unprivileged workflow.