refresh AWS credentials if using task role#2104
Closed
vagelim wants to merge 6 commits into
Closed
Conversation
should prob condition on near-term expiry of session
dosubot
Bot
added
size:S
acco
force-pushed
the
main
branch
2 times, most recently
from
caf756f to
3fdb0d5
Compare
dosubot
Bot
added
size:M
Author
Author
|
just wanted to check in on what is needed to get this in @RTLS |
Author
|
We have since moved away from sequin so I will no longer be monitoring this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Adds a refresh to the aws credentials to account for temporary credential expiry when using IAM roles instead of static credentials.
This addresses an issue reported in #2078
This patch is running in production for me under real loads.
why
This is a bandaid for a patch that should be applied upstream in the base AWS lib for elixir but I needed to get it working for my case. I am working on a patch to aws-elixir but am not ready to submit.